Updated to new version and all instruments on panels are wrong size

Discuss suspected bugs with other users and Sim Innovations Staff

Moderators: russ, Ralph

Message
Author
User avatar
Corjan
Posts: 2936
Joined: Thu Nov 19, 2015 9:04 am

Re: Updated to new version and all instruments on panels are wrong size

#11 Post by Corjan »

Hi,


These things are always a bit gray.

But making a change in AM that will break a lot of instruments is not really smart I think ;)
Our own instruments are fine, we can fix those. But there are a bunch of instruments that people made themselves that might break.


Corjan

User avatar
Sling
Posts: 5237
Joined: Mon Sep 11, 2017 2:37 pm
Contact:

Re: Updated to new version and all instruments on panels are wrong size

#12 Post by Sling »

Corjan wrote: Thu Apr 21, 2022 5:09 am Hi,


We made a change to the API that looking back wasn't very smart.
Multiple functions that where accepting numbers would now only accept integer values (without decimal point).

Although technically correct and clean, that is causing quite some issues.

I will revert this change and push a hotfix for Air Manager. Probably today.


Sorry for the trouble,

Corjan
Curious as to why that would break switch_set_position. Perhaps folks are subscribing to MSFS variables with the number type and using that to drive the switch position change. Unless it has to be a number type Enum can be used. Haven’t checked this theory because I held off from 4.1.2.

User avatar
Corjan
Posts: 2936
Joined: Thu Nov 19, 2015 9:04 am

Re: Updated to new version and all instruments on panels are wrong size

#13 Post by Corjan »

Hi,


FS2020 variables are normally lua number type expect enum and bool I think.
For X-plane it will be a lua integer when subscribed as X-plane INT, otherwise also lua number.


So yeah, it all makes sense :)

Corjan

User avatar
Crunchmeister
Posts: 222
Joined: Tue Aug 10, 2021 2:06 pm

Re: Updated to new version and all instruments on panels are wrong size

#14 Post by Crunchmeister »

Thank you for the update, @Corjan. Everything works as it should again.
- Ryzen 5950x, 64GB 3600MHz RAM, RTX3070Ti

Simstrumentation Instrument dev
Free Air Manager instruments for MSFS available at http://www.simstrumentation.com

User avatar
skypilotYTS
Posts: 9
Joined: Thu Apr 21, 2022 1:09 am
Location: CYTS

Re: Updated to new version and all instruments on panels are wrong size

#15 Post by skypilotYTS »

Corjan wrote: Thu Apr 21, 2022 5:09 am Hi,


We made a change to the API that looking back wasn't very smart.
Multiple functions that where accepting numbers would now only accept integer values (without decimal point).

Although technically correct and clean, that is causing quite some issues.

I will revert this change and push a hotfix for Air Manager. Probably today.


Sorry for the trouble,

Corjan
Thank you sir,

I just tested on the instruments I was having issues with and confirmed they are again working after todays update.

Thanks!

User avatar
Keith Baxter
Posts: 4674
Joined: Wed Dec 20, 2017 11:00 am
Location: Botswana

Re: Updated to new version and all instruments on panels are wrong size

#16 Post by Keith Baxter »

Crunchmeister wrote: Thu Apr 21, 2022 1:25 pm Thank you for the update, @Corjan. Everything works as it should again.
Hi,

That is great news,

I still question the wisdom of perpetuating non standard coding practice. If the issue is instrument code related, then the off side instruments need to be brought up to code. If it is the way AM handles code within the different sim's then the plugins need to be sorted.

Just hope this back-track does not restrict AM down the road.

What I am saying is, Corjan has advancements in mind, I assume, else he would not have changed the API. Will this back-track affect other enhancements to AM that will take AM to another level and keep us to a level that has been very similar for a few years now ?

Keith
AMD RYZEN 9 5950X CPU, Corsair H80I cooler, ASUS TUF GAMING B550-PLUS AMD Ryzen Mother Board,  32Gb ram Corsair Vengeance 3000Mh, MSI GTX960 4G graphics card 

User avatar
Sling
Posts: 5237
Joined: Mon Sep 11, 2017 2:37 pm
Contact:

Re: Updated to new version and all instruments on panels are wrong size

#17 Post by Sling »

Keith,

For what it’s worth I agree. If everyone uses the correct subscribe type or if not possible ensures the arguments are of the right type before using in those functions then perhaps down the track this can be rolled in again. I’ll be looking for this now with new submissions to help standardise moving forward. It makes sense to keep as is for now so you don’t suddenly force a big issue with backwards compatibility. Certainly something that could be worked towards though.

GoodSim
Posts: 33
Joined: Thu Apr 30, 2020 2:49 pm
Location: New Orleans, Louisiana USA

Re: Updated to new version and all instruments on panels are wrong size

#18 Post by GoodSim »

Whew! That’s a relief. Thanks, everyone. For a second there, I thought that my computer had been “invaded”.

User avatar
Keith Baxter
Posts: 4674
Joined: Wed Dec 20, 2017 11:00 am
Location: Botswana

Re: Updated to new version and all instruments on panels are wrong size

#19 Post by Keith Baxter »

GoodSim wrote: Thu Apr 21, 2022 3:16 pm Whew! That’s a relief. Thanks, everyone. For a second there, I thought that my computer had been “invaded”.
Hi,

I think @Corjan and @Sling peeps should report what instruments and panels with the respective sim that had the issue. That way Tony could revert to the author of the instrument to fix. Or if the instrument is self coded or cloned by a user it is up to the user to get it to compliance.

The policy taken now can have ripples down the line. Just my 1p

Keith
AMD RYZEN 9 5950X CPU, Corsair H80I cooler, ASUS TUF GAMING B550-PLUS AMD Ryzen Mother Board,  32Gb ram Corsair Vengeance 3000Mh, MSI GTX960 4G graphics card 

User avatar
Corjan
Posts: 2936
Joined: Thu Nov 19, 2015 9:04 am

Re: Updated to new version and all instruments on panels are wrong size

#20 Post by Corjan »

Hi,


Well, for now this is fine I think.
There is no real reason to force an integer in this case, besides that it feels cleaner from a technical standpoint.

It is okay if the API is a bit forgiving where it can be.


Corjan

Post Reply